processor/metricstransformprocessor bug report, more detail in description

[JimChenWYU]

Component(s)

processor/metricstransform

What happened?

Description

In processor/metricstransformprocessor/metrics_transform_processor_testcases_test.go, I add a test case

{
	name: "test kafka cpu time",
	transforms: []internalTransform{
		{
			NewName: "kafka_cpu_time_seconds_total",
			MetricIncludeFilter: func() internalFilter {
				filter, _ := createFilter(FilterConfig{
					Include:   "process_all_cpu_time_seconds_total",
					MatchType: StrictMatchType,
					MatchLabels: map[string]string{
						"cwd":   "/usr/local/kafka",
						"pname": "java",
					},
				})
				return filter
			}(),
			Action: Insert,
		},
		{
			NewName:             "kafka_cpu_time_seconds_total",
			MetricIncludeFilter: internalFilterStrict{include: "kafka_cpu_time_seconds_total"},
			Action:              Combine,
			AggregationType:     Max,
		},
		{
			MetricIncludeFilter: internalFilterStrict{include: "kafka_cpu_time_seconds_total"},
			Action:              Update,
			Operations: []internalOperation{
				{
					configOperation: Operation{
						Action:          AggregateLabels,
						AggregationType: Max,
					},
				},
			},
		},
	},
	in: []pmetric.Metric{
		metricBuilder(pmetric.MetricTypeSum, "process_all_cpu_time_seconds_total", "cwd", "pid", "pname").
			addDoubleDatapoint(1, 2, 0.02, "/usr/local/kafka", "1821184", "bash").
			addDoubleDatapoint(1, 2, 1.4200000000000002, "/usr/local/kafka", "1821702", "java").
			addDoubleDatapoint(1, 2, 0, "/usr/local/kafka", "1821703", "grep").
			addDoubleDatapoint(1, 2, 0.02, "/usr/local/kafka", "1829456", "bash").
			addDoubleDatapoint(1, 2, 3.95, "/usr/local/kafka", "1829511", "java").
			addDoubleDatapoint(1, 2, 13008.900000000001, "/usr/local/kafka", "685117", "java").
			build(),
	},
	out: []pmetric.Metric{
		metricBuilder(pmetric.MetricTypeSum, "process_all_cpu_time_seconds_total", "cwd", "pid", "pname").
			addDoubleDatapoint(1, 2, 0.02, "/usr/local/kafka", "1821184", "bash").
			addDoubleDatapoint(1, 2, 1.4200000000000002, "/usr/local/kafka", "1821702", "java").
			addDoubleDatapoint(1, 2, 0, "/usr/local/kafka", "1821703", "grep").
			addDoubleDatapoint(1, 2, 0.02, "/usr/local/kafka", "1829456", "bash").
			addDoubleDatapoint(1, 2, 3.95, "/usr/local/kafka", "1829511", "java").
			addDoubleDatapoint(1, 2, 13008.900000000001, "/usr/local/kafka", "685117", "java").
			build(),
		metricBuilder(pmetric.MetricTypeSum, "kafka_cpu_time_seconds_total", "cwd", "pid", "pname").
			addDoubleDatapoint(1, 2, 1.4200000000000002, "/usr/local/kafka", "1821702", "java").
                         addDoubleDatapoint(1, 2, 3.95, "/usr/local/kafka", "1829511", "java").
			addDoubleDatapoint(1, 2, 13008.900000000001, "/usr/local/kafka", "685117", "java").
			build(),
	},
},

Steps to Reproduce

Run unit test

Expected Result

out should be

	out: []pmetric.Metric{
		metricBuilder(pmetric.MetricTypeSum, "process_all_cpu_time_seconds_total", "cwd", "pid", "pname").
			addDoubleDatapoint(1, 2, 0.02, "/usr/local/kafka", "1821184", "bash").
			addDoubleDatapoint(1, 2, 1.4200000000000002, "/usr/local/kafka", "1821702", "java").
			addDoubleDatapoint(1, 2, 0, "/usr/local/kafka", "1821703", "grep").
			addDoubleDatapoint(1, 2, 0.02, "/usr/local/kafka", "1829456", "bash").
			addDoubleDatapoint(1, 2, 3.95, "/usr/local/kafka", "1829511", "java").
			addDoubleDatapoint(1, 2, 13008.900000000001, "/usr/local/kafka", "685117", "java").
			build(),
		metricBuilder(pmetric.MetricTypeSum, "kafka_cpu_time_seconds_total", "cwd", "pid", "pname").
			addDoubleDatapoint(1, 2, 13008.900000000001, "/usr/local/kafka", "685117", "java").
			build(),
	},

Actual Result

	out: []pmetric.Metric{
		metricBuilder(pmetric.MetricTypeSum, "process_all_cpu_time_seconds_total", "cwd", "pid", "pname").
			addDoubleDatapoint(1, 2, 0.02, "/usr/local/kafka", "1821184", "bash").
			addDoubleDatapoint(1, 2, 1.4200000000000002, "/usr/local/kafka", "1821702", "java").
			addDoubleDatapoint(1, 2, 0, "/usr/local/kafka", "1821703", "grep").
			addDoubleDatapoint(1, 2, 0.02, "/usr/local/kafka", "1829456", "bash").
			addDoubleDatapoint(1, 2, 3.95, "/usr/local/kafka", "1829511", "java").
			addDoubleDatapoint(1, 2, 13008.900000000001, "/usr/local/kafka", "685117", "java").
			build(),
		metricBuilder(pmetric.MetricTypeSum, "kafka_cpu_time_seconds_total", "cwd", "pid", "pname").
			addDoubleDatapoint(1, 2, 1.4200000000000002, "/usr/local/kafka", "1821702", "java").
                         addDoubleDatapoint(1, 2, 3.95, "/usr/local/kafka", "1829511", "java").
			addDoubleDatapoint(1, 2, 13008.900000000001, "/usr/local/kafka", "685117", "java").
			build(),
	},

Is it a bug？

Collector version

v0.79.0

Environment information

Environment

OS: (e.g., "Ubuntu 20.04")
Compiler(if manually compiled): (e.g., "go 14.2")

OS: macOSX
Compiler: go1.20.4

OpenTelemetry Collector configuration

No response

Log output

No response

Additional context

No response

[github-actions]

Pinging code owners:

• processor/metricstransform: @dmitryax

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[github-actions]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

• processor/metricstransform: @dmitryax
• needs: Github issue template generation code needs this to generate the corresponding labels.

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[crobert-1]

@JimChenWYU I just tried your test on the latest version of the collector, and it's passing as expected.

    --- PASS: TestMetricsTransformProcessor/test_kafka_cpu_time (0.00s)

Can you test again? Sorry for taking so long to respond!

[crobert-1]

I thought a bit more about this and I think this can be closed as completed since the test is passing. Feel free to open a PR adding the test, or let us know if there's anything else to do here.