Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/k8sevents] Allow excluding namespaces #23991

Open
Zahlii opened this issue Jul 5, 2023 · 6 comments
Open

[receiver/k8sevents] Allow excluding namespaces #23991

Zahlii opened this issue Jul 5, 2023 · 6 comments
Labels
enhancement New feature or request never stale Issues marked with this label will be never staled and automatically removed receiver/k8sevents

Comments

@Zahlii
Copy link

Zahlii commented Jul 5, 2023

Component(s)

receiver/k8sevents

Is your feature request related to a problem? Please describe.

In many scenarios I am not interested in events in. certain namespaces 8e.g. istio, kyma, kube-system). However, I would like to per default monitor all other namespaces, as there are users who can freely create namespaces on the cluster that should automatucally be monitored.

Describe the solution you'd like

In addition to allow namespaces = [xxx], it would be helpful to also have exclude_namespaces = [xxx], or even better a regex based approach.

Describe alternatives you've considered

No response

Additional context

No response

@Zahlii Zahlii added enhancement New feature or request needs triage New item requiring triage labels Jul 5, 2023
@Zahlii Zahlii changed the title Allow excluding namespaces [receiver/k8sevents] Allow excluding namespaces Jul 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2023

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

  • receiver/k8sevents: @dmitryax @TylerHelmuth
  • needs: Github issue template generation code needs this to generate the corresponding labels.

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@crobert-1
Copy link
Member

Sounds like a valid request to me.

In the meanwhile, it looks like the namespace is added as a log attribute. Since this is the case, you can use the filter processor to drop all logs from the namespaces that you want to exclude. Look at the alternative config options for logs to see how this could be done.

I'll remove needs triage for now, but the code owners may decide to simply rely on the filter processor instead of implementing this in the receiver. I'll defer to their judgement.

@crobert-1 crobert-1 removed needs triage New item requiring triage Stale labels Oct 12, 2023
@TylerHelmuth
Copy link
Member

This is a good idea. Also likely impacted by #25161

Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Feb 12, 2024
@crobert-1 crobert-1 added never stale Issues marked with this label will be never staled and automatically removed and removed Stale labels Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request never stale Issues marked with this label will be never staled and automatically removed receiver/k8sevents
Projects
None yet
Development

No branches or pull requests

3 participants