Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pkg/stanza] syslog input not initializing OctetMultiLineBuilder #24073

Closed
timannguyen opened this issue Jul 10, 2023 · 3 comments
Closed

[pkg/stanza] syslog input not initializing OctetMultiLineBuilder #24073

timannguyen opened this issue Jul 10, 2023 · 3 comments
Labels
bug Something isn't working pkg/stanza

Comments

@timannguyen
Copy link
Contributor

timannguyen commented Jul 10, 2023

Component(s)

pkg/stanza

What happened?

Description

the following change in https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/pkg/stanza/operator/input/syslog/syslog.go#L64-L66 is being over written on https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/pkg/stanza/operator/input/syslog/syslog.go#L68. the lines

if syslogParserCfg.EnableOctetCounting {
	tcpInputCfg.MultiLineBuilder = OctetMultiLineBuilder
}

should be moved to set after

tcpInputCfg.BaseConfig = *c.TCP

to prevent being overwritten.

Steps to Reproduce

enable enable_octet_counting = true and the multiline builder is using the default.

Expected Result

Actual Result

Collector version

v0.81.0

Environment information

Environment

OS: (e.g., "Ubuntu 20.04")
Compiler(if manually compiled): (e.g., "go 14.2")
go 20.0

OpenTelemetry Collector configuration

No response

Log output

No response

Additional context

No response

@timannguyen timannguyen added bug Something isn't working needs triage New item requiring triage labels Jul 10, 2023
@github-actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@timannguyen
Copy link
Contributor Author

timannguyen commented Jul 10, 2023

i'll push a fix for it. if someone can assign this to me. :)

@djaglowski djaglowski removed the needs triage New item requiring triage label Jul 10, 2023
@djaglowski
Copy link
Member

Thanks @timannguyen. I can't assign the issue to you because you are not yet a member of the OpenTelemetry org, but I'll happily review your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pkg/stanza
Projects
None yet
Development

No branches or pull requests

2 participants