Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kafka: Support encrypted TLS keys #25154

Closed
pranavmarla opened this issue Aug 10, 2023 · 6 comments
Closed

Kafka: Support encrypted TLS keys #25154

pranavmarla opened this issue Aug 10, 2023 · 6 comments

Comments

@pranavmarla
Copy link

pranavmarla commented Aug 10, 2023

Component(s)

exporter/kafka, receiver/kafka

Is your feature request related to a problem? Please describe.

Currently, the OTel Kafka clients (exporter and receiver) support TLS authentication via a private key (auth.tls.key_file). However, that key has to be unencrypted, which seems like a security risk. By contrast, the built-in Kafka clients support encrypted TLS keys (specifically, they have an extra param that takes in the password for the TLS key: link)

Describe the solution you'd like

The OTel Kafka clients should have an extra param that takes in a password for the TLS key, just like the built-in Kafka clients. This enables us to authenticate via encrypted TLS key, instead of requiring the key to be unencrypted.

Describe alternatives you've considered

Currently, the only alternative seems to be to remove password protection from the TLS key and supply the unencrypted key to the OTel agent, which seems like a security risk.

Additional context

No response

@pranavmarla pranavmarla added enhancement New feature or request needs triage New item requiring triage labels Aug 10, 2023
@github-actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@atoulme
Copy link
Contributor

atoulme commented Sep 9, 2023

This would be best handled through a config provider that would inject the configuration. One such possibility is to use an environment variable for example.

@atoulme atoulme removed the needs triage New item requiring triage label Sep 9, 2023
@pranavmarla
Copy link
Author

pranavmarla commented Sep 9, 2023

This would be best handled through a config provider that would inject the configuration. One such possibility is to use an environment variable for example.

Thanks @atoulme. So you're saying you don't think this is a feature that should be built into OTEL itself?

@atoulme
Copy link
Contributor

atoulme commented Sep 9, 2023

I am saying it should not be specific to this field. It should be a feature available for any field.

Copy link
Contributor

github-actions bot commented Nov 9, 2023

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Nov 9, 2023
Copy link
Contributor

github-actions bot commented Jan 8, 2024

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants