Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[extension/jaegerremotesampling]: Remove featuregate switch from Thrift-gen with Proto-gen #26483

Closed
frzifus opened this issue Sep 6, 2023 · 5 comments

Comments

@frzifus
Copy link
Member

frzifus commented Sep 6, 2023

Component(s)

extension/jaegerremotesampling

Describe the issue you're reporting

Its a follow-up to #18485.

Right now there is a feature flag to use the Protobuf-gen struct used in the Jaeger 1.42 samplingStore impl. instead of the old Thrift-gen struct. With version 0.88.0 the Thrift-gen struct implementation should be dropped.

See:

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

Pinging code owners for extension/jaegerremotesampling: @jpkrohling @frzifus. See Adding Labels via Comments if you do not have permissions to add labels yourself.

Copy link
Contributor

github-actions bot commented Nov 7, 2023

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Nov 7, 2023
@frzifus frzifus removed the Stale label Nov 7, 2023
@jpkrohling
Copy link
Member

@frzifus, time to drop the feature flag?

@frzifus
Copy link
Member Author

frzifus commented Nov 27, 2023

We agreed on dropping it after the next release, since it was not operational in the beginning.

@frzifus
Copy link
Member Author

frzifus commented Dec 8, 2023

@frzifus frzifus closed this as completed Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants