Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spans waiting for Tail Sampling Processor decision are lost if OTEL Collector restarts #26490

Closed
lsolovey opened this issue Sep 6, 2023 · 4 comments
Labels
enhancement New feature or request processor/tailsampling Tail sampling processor Stale

Comments

@lsolovey
Copy link

lsolovey commented Sep 6, 2023

Component(s)

processor/tailsampling

Describe the issue you're reporting

We noticed that spans waiting in memory for Tail Sampling Processor decision (based on decision_wait setting of Tail Sampling Processor) are lost if OTEL Collector is restarted.

Should Tail Sampling Processor support graceful shutdown to avoid loss of spans?

@lsolovey lsolovey added the needs triage New item requiring triage label Sep 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the processor/tailsampling Tail sampling processor label Sep 6, 2023
@jpkrohling jpkrohling added enhancement New feature or request and removed needs triage New item requiring triage labels Sep 8, 2023
@jpkrohling
Copy link
Member

It would certainly be interesting to have this feature. How are you planning to approach that?

Copy link
Contributor

github-actions bot commented Nov 8, 2023

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Nov 8, 2023
@jpkrohling
Copy link
Member

There's no plan for adding a WAL to this component at this point. I'm closing, unless we have someone willing to create a design doc with a proposal for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request processor/tailsampling Tail sampling processor Stale
Projects
None yet
Development

No branches or pull requests

2 participants