Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circuit breaker for receiver/prometheus and exporter/prometheusremotewrite #26996

Closed
premendrasingh opened this issue Sep 19, 2023 · 5 comments
Closed

Comments

@premendrasingh
Copy link
Contributor

Component(s)

cmd/otelcontribcol, exporter/prometheusremotewrite, receiver/prometheus

Is your feature request related to a problem? Please describe.

We use receiver/prometheus to scrape prometheus metrics and exporter/prometheusremotewrite to write those metrics using otelcol to Prometheus. Sometimes the applications don't expose metrics to harvest and sometimes when prometheus server or network issues cause otel-collector queues to get filled and get OOM killed.

Describe the solution you'd like

I would like to propose a circuit breaker implemented at receiver and exporter level so that when an endpoint is unresponsive, the circuit breaker pattern can help prevent cascading failures, while the services are trying to recover. It will handle errors gracefully, reduce application downtimes and help the services to recover more efficiently. State changes of the circuit breaker can be used for error monitoring.

Describe alternatives you've considered

A retry option with back-off can work, but circuit breaker will be much more efficient.

Additional context

No response

@premendrasingh premendrasingh added enhancement New feature or request needs triage New item requiring triage labels Sep 19, 2023
@github-actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@dashpole
Copy link
Contributor

I would consider using the memory limiter processor, and reducing the size of the queue in the queued retry section of the prometheus remote write exporter. You may also consider using the (disk-based) WAL in the prometheus remote write exporter to buffer to disk instead of memory.

@premendrasingh
Copy link
Contributor Author

Thanks for the suggestions, I will try them.

@crobert-1
Copy link
Member

@premendrasingh Have you been able to try the memory limiter processor yet? Does this fit your use case?

Copy link
Contributor

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants