Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/kubeletstats] volume metrics should include pvc reference #31728

Closed
stoetti opened this issue Mar 13, 2024 · 5 comments
Closed

[receiver/kubeletstats] volume metrics should include pvc reference #31728

stoetti opened this issue Mar 13, 2024 · 5 comments
Labels

Comments

@stoetti
Copy link

stoetti commented Mar 13, 2024

Component(s)

receiver/kubeletstats

Is your feature request related to a problem? Please describe.

We want to monitor the available disk space of persistent volumes but the receiver does not provide any information to differentiate by volume type (pvc, emptydir, configmap, ...)

Describe the solution you'd like

The stats endpoint of the kubelet returns a field "pvcref" for volumes of type persistentVolumeClaim. Adding the name and namespace from that field as label would make it possible to monitor actual disk usage for persistent volumes.

Describe alternatives you've considered

No response

Additional context

No response

@stoetti stoetti added enhancement New feature or request needs triage New item requiring triage labels Mar 13, 2024
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@stoetti stoetti changed the title volume metrics should include pvc reference [receiver/kubeletstats] volume metrics should include pvc reference Mar 13, 2024
@TylerHelmuth
Copy link
Member

@stoetti does the resource attribute k8s.volume.name contain the information you're looking for?

@TylerHelmuth TylerHelmuth added waiting for author and removed needs triage New item requiring triage labels Mar 13, 2024
@stoetti
Copy link
Author

stoetti commented Mar 14, 2024

Unfortunately not as we want to monitor for all workloads in the cluster and the volume name is not an indicator for the type of the volume. This can also not be established as we run external components.

@jinja2
Copy link
Contributor

jinja2 commented Mar 15, 2024

We do support a subset of volume types and the pvc name is available as attr. You'll need to enable it with the below config

kubeletstats:
  extra_metadata_labels:
    - k8s.volume.type

Example metric with the attribute k8s.persistentvolumeclaim.name
image

@stoetti
Copy link
Author

stoetti commented Mar 18, 2024

We do support a subset of volume types and the pvc name is available as attr. You'll need to enable it with the below config

kubeletstats:
  extra_metadata_labels:
    - k8s.volume.type

Example metric with the attribute k8s.persistentvolumeclaim.name image

Great that is exactly what I was looking for 👏
It would be helpful to point that out in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants