Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/elasticsearch] Support both v7 and v8 elasticsearch clients and default to v8 #32454

Open
carsonip opened this issue Apr 16, 2024 · 4 comments
Labels

Comments

@carsonip
Copy link
Contributor

carsonip commented Apr 16, 2024

Component(s)

exporter/elasticsearch

Is your feature request related to a problem? Please describe.

Currently elasticsearch exporter uses go-elasticsearch v7 because of the "forward compatibility" described in https://github.com/elastic/go-elasticsearch?tab=readme-ov-file#elasticsearch and raised in #16310. However, this means that v8 stack users are also forced to use go-elasticsearch v7 as mentioned in #29689. v8 go-elasticsearch client gets the bugfixes and features that may not be available in v7 go-elasticsearch client. Elasticsearch exporter should support both v7 and v8 elasticsearch client, and ideally default to v8 (which may be a breaking change).

Describe the solution you'd like

  • Support both v7 and v8 go-elasticsearch client and expose it as a configuration option.
  • Default to v8 client

Describe alternatives you've considered

No response

Additional context

Related to #32378

@carsonip carsonip added enhancement New feature or request needs triage New item requiring triage labels Apr 16, 2024
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@JaredTan95
Copy link
Member

Agree, this upgrade has been mentioned many times and I think it is a necessary upgrade

@JaredTan95 JaredTan95 removed the needs triage New item requiring triage label Apr 18, 2024
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Jun 17, 2024
@carsonip
Copy link
Contributor Author

carsonip commented Jun 17, 2024

Still relevant, and this should be ready to implement as elasticsearchexporter is now using go-docappender

@github-actions github-actions bot removed the Stale label Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants