Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for Job and Instance Labels for Prometheus receiver #5998

Closed
mustafain117 opened this issue Oct 29, 2021 · 3 comments
Closed

Add test for Job and Instance Labels for Prometheus receiver #5998

mustafain117 opened this issue Oct 29, 2021 · 3 comments
Labels
ci-cd CI, CD, testing, build issues closed as inactive comp:prometheus Prometheus related issues comp: receiver Receiver Stale

Comments

@mustafain117
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Currently, the Prometheus receiver test for labels only checks for the presence of external labels. We want to validate the presence of job and instance labels in every timeseries.

Describe the solution you'd like
We propose the following solution:

Similar to the test for external labels

Add a test for job and instance labels that will setup a static target for the Prometheus receiver to scrape, the metrics sent by the receiver to the Metrics sink can then be validated to assert that the job labels and instance labels are present in each scrape with the correct expected values.

Additional context
Related to : open-telemetry/wg-prometheus#57

CC: @alolita @Aneurysm9

@alolita alolita added comp:prometheus Prometheus related issues ci-cd CI, CD, testing, build issues comp: receiver Receiver labels Nov 2, 2021
@mustafain117
Copy link
Contributor Author

@alolita please assign this issue to me.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2022

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Nov 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2023

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-cd CI, CD, testing, build issues closed as inactive comp:prometheus Prometheus related issues comp: receiver Receiver Stale
Projects
None yet
Development

No branches or pull requests

2 participants