Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Prometheus Remote Write Exporter] Ensure Prometheus Remote Write Exporter respond to OTLP data format from Prometheus Receiver #6620

Closed
JamesJHPark opened this issue Dec 7, 2021 · 1 comment
Assignees
Labels
comp: exporter Exporter comp:prometheus Prometheus related issues

Comments

@JamesJHPark
Copy link
Contributor

JamesJHPark commented Dec 7, 2021

Is your feature request related to a problem? Please describe.
In regards to the issue #6376, the metric builder does not assign staleNaN values to the histogram and summary values for failed scrapes from Prometheus scrape loop. Therefore, the proposed possible solution is to use the OTLP format in the OTLP Prometheus Receiver with datapoint flags as a staleness marker for metrics with no-value present to address this issue.

Accordingly, if the metrics in the Prometheus Remote Write Exporter contain the OTLP flag that indicates MetricDataPointFlagNoRecordedValue, the Prometheus Remote Write Exporter should be able to handle and respond to the OTLP flag for staleness. This allows end-to-end compatibility in the collector pipeline with the use of OTLP native staleness marker flag, from the Prometheus Receiver to the Prometheus Remote Write Exporter.

Describe the solution you'd like
A possible solution is to check every data point for all metrics data types for the OTLP MetricDataPointFlagNoRecordedValue flag, and set the sample value of the data point containing this flag to the StaleNaN value. This ensures the Prometheus Remote Write Exporter to handle and respond to the OTLP flag for staleness in the collector pipeline.

Additional context
Related issue: #6376

cc @alolita

@alolita
Copy link
Member

alolita commented Dec 14, 2021

Completed. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: exporter Exporter comp:prometheus Prometheus related issues
Projects
None yet
Development

No branches or pull requests

2 participants