Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prometheus dependency is really old #8243

Closed
dashpole opened this issue Mar 1, 2022 · 5 comments
Closed

Prometheus dependency is really old #8243

dashpole opened this issue Mar 1, 2022 · 5 comments
Labels
comp:prometheus Prometheus related issues dependencies Pull requests that update a dependency file

Comments

@dashpole
Copy link
Contributor

dashpole commented Mar 1, 2022

Description

We are on version v1.8.2 of prometheus, which is from 2017. We may see better performance, etc. if we update.
@dashpole dashpole added dependencies Pull requests that update a dependency file comp:prometheus Prometheus related issues labels Mar 1, 2022
@dashpole
Copy link
Contributor Author

dashpole commented Mar 1, 2022

cc @Aneurysm9

@jpkrohling
Copy link
Member

I thought @gouthamve changed this already?

@mx-psi
Copy link
Member

mx-psi commented Mar 2, 2022 •
edited

We are not using v1.8.2, we are pinning this commit: prometheus/prometheus@4855a0c067e2 from Jan 17th 2022. v1.8.2-0.20220117154355-4855a0c067e2 is a pseudo-version. We can't use an actual v2 version tag because of prometheus/prometheus#8852

@kwiesmueller
Copy link

That's interesting.
I updated Prometheus yesterday for our 0.37.0 fork and there I had to make a few changes to imports to make it possible.
Maybe that was before you changed your pinned commit.

@dashpole
Copy link
Contributor Author

dashpole commented Mar 2, 2022

Thanks. Sorry for the confusion.

@dashpole dashpole closed this as completed Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp:prometheus Prometheus related issues dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jpkrohling @dashpole @mx-psi @kwiesmueller