Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[processor/k8sattributes] Apply strict regex matching on the full length of labels/annotations #9716

Closed
dmitryax opened this issue May 3, 2022 · 2 comments
Closed

[processor/k8sattributes] Apply strict regex matching on the full length of labels/annotations #9716

dmitryax opened this issue May 3, 2022 · 2 comments
Assignees
@erenming
Labels
good first issue Good for newcomers help wanted Extra attention is needed priority:p3 Lowest processor/k8sattributes k8s Attributes processor

Comments

@dmitryax
Copy link
Member

dmitryax commented May 3, 2022

As discussed in this thread we should apply key_regex value to the full length of annotations and labels. For example:

  • key_regex: an* should not match annotation1 pod label, but match annn label.
  • key_regex: .* should match any pod label.
@dmitryax dmitryax mentioned this issue May 3, 2022
Merged
@dmitryax dmitryax added help wanted Extra attention is needed good first issue Good for newcomers processor/k8sattributes k8s Attributes processor priority:p3 Lowest labels May 6, 2022
@erenming
Copy link
Contributor

erenming commented Aug 9, 2022 •
edited

Hi, i'd like to resolve this issue, could assign it to me? @dmitryax

@dmitryax
Copy link
Member Author

dmitryax commented Aug 9, 2022

@erenming, assigned. Thank you!

@erenming erenming mentioned this issue Aug 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erenming erenming

Labels
good first issue Good for newcomers help wanted Extra attention is needed priority:p3 Lowest processor/k8sattributes k8s Attributes processor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dmitryax @erenming