Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/k8scluster] deprecate k8s.kubeproxy.version attr #29748

Closed
jinja2 opened this issue Dec 11, 2023 · 3 comments
Closed

[receiver/k8scluster] deprecate k8s.kubeproxy.version attr #29748

jinja2 opened this issue Dec 11, 2023 · 3 comments
Labels

Comments

@jinja2
Copy link
Contributor

jinja2 commented Dec 11, 2023

Component(s)

receiver/k8scluster

Is your feature request related to a problem? Please describe.

k8scluster receiver has the optional attribute k8s.kubeproxy.version, the value of which is set to the v1.Node field .status.nodeInfo.kubeProxyVersion. This field is not accurate and is set by kubelet, which does not actually know the kube-proxy version, or even if kube-proxy is running. k8s v1.29 starts the deprecation process of this field.

Describe the solution you'd like

We should start deprecation of the k8s.kubeproxy.version attribute given the value is not accurate, and k8s itself plans to remove it.

Describe alternatives you've considered

No response

Additional context

No response

@jinja2 jinja2 added enhancement New feature or request needs triage New item requiring triage labels Dec 11, 2023
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@povilasv
Copy link
Contributor

I agree, thanks for the issue. Opened PR for this -> #29768

@crobert-1 crobert-1 removed the needs triage New item requiring triage label Dec 12, 2023
TylerHelmuth pushed a commit that referenced this issue Dec 12, 2023
…te (#29768)

**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->

Deprecating k8s.kubeproxy.version resource attribute 


**Link to tracking Issue:** <Issue number if applicable>


#29748

**Testing:** <Describe what testing was performed and which tests were
added.>

**Documentation:** <Describe the documentation added.>
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Feb 12, 2024
dmitryax pushed a commit that referenced this issue Feb 27, 2024
…31180)

**Description:** Remove deprecated resource attribute. Deprecation happened in 0.92.0

**Link to tracking Issue:** #29748 (comment)
XinRanZhAWS pushed a commit to XinRanZhAWS/opentelemetry-collector-contrib that referenced this issue Mar 13, 2024
…pen-telemetry#31180)

**Description:** Remove deprecated resource attribute. Deprecation happened in 0.92.0

**Link to tracking Issue:** open-telemetry#29748 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants