Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/vcenter] Host Resource Should Not Have vcenter.cluster.name Attribute if Standalone (Not Clustered) #32548

Closed
StefanKurek opened this issue Apr 19, 2024 · 2 comments
Labels
bug Something isn't working receiver/vcenter

Comments

@StefanKurek
Copy link
Contributor

Component(s)

receiver/vcenter

What happened?

Description

Having a vcenter.cluster.name attribute with a value of the Host name (duplicated by the vcenter.host.name attribute) returned for Standalone Host resources could be confusing for a customer in understanding which hosts are standalone or clustered.

A cluster attribute doesn’t make sense for a Standalone Host, as they do not have any concept of a cluster related to them (currently children resources of standalone hosts like VMs or resource pools do not have this extra cluster attribute, so there’s not a good reason for the Host resource to have it either).

Steps to Reproduce

Collect against any vCenter environment with a vCenter Standalone Host

Expected Result

Returned Standalone Host resources should not have a vcenter.cluster.name attribute

Actual Result

Returned Standalone Host resources DO have a vcenter.cluster.name attribute

Collector version

v1.5.0/v0.98.0

Environment information

No response

OpenTelemetry Collector configuration

extensions:
  basicauth/prom:
    client_auth:
      username: [PROMUSER]
      password: [PROMPASS]

exporters:
  prometheusremotewrite:
    endpoint: [PROMENDPOINT]
    auth:
      authenticator: basicauth/prom
    resource_to_telemetry_conversion:
      enabled: true # Convert resource attributes to metric labels

processors:
  batch:
    # https://github.com/open-telemetry/opentelemetry-collector/tree/main/processor/batchprocessor

receivers:
  vcenter:
    endpoint: https://[VCENTERHOST]
    username: [VCENTERUSER]
    password: [VCENTERPASS]
    tls:
      insecure: true
    collection_interval: 1m
    initial_delay: 1s

service:
  extensions: [basicauth/prom]
  pipelines:
    metrics:
      receivers: [vcenter]
      processors: [batch]
      exporters: [prometheusremotewrite]

Log output

No response

Additional context

No response

@StefanKurek StefanKurek added bug Something isn't working needs triage New item requiring triage labels Apr 19, 2024
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@djaglowski djaglowski removed the needs triage New item requiring triage label Apr 19, 2024
djaglowski pushed a commit that referenced this issue Apr 19, 2024
…m standalone Host resources (#32549)

**Description:** <Describe what has changed.>
vcenter.cluster.name attribute is removed from all Host resources that
have a ComputeResource parent (vs. a ClusterComputeResource) parent.

This helps to not cause confusion by making standalone hosts look like
clustered hosts.

**Link to tracking Issue:** <Issue number if applicable>
#32548 

**Testing:** <Describe what testing was performed and which tests were
added.>
Unit/integration tests updated and tested. Local environment tested.

**Documentation:** <Describe the documentation added.>
N/A
@crobert-1
Copy link
Member

I believe this was resolved by #32549

rimitchell pushed a commit to rimitchell/opentelemetry-collector-contrib that referenced this issue May 8, 2024
…m standalone Host resources (open-telemetry#32549)

**Description:** <Describe what has changed.>
vcenter.cluster.name attribute is removed from all Host resources that
have a ComputeResource parent (vs. a ClusterComputeResource) parent.

This helps to not cause confusion by making standalone hosts look like
clustered hosts.

**Link to tracking Issue:** <Issue number if applicable>
open-telemetry#32548 

**Testing:** <Describe what testing was performed and which tests were
added.>
Unit/integration tests updated and tested. Local environment tested.

**Documentation:** <Describe the documentation added.>
N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working receiver/vcenter
Projects
None yet
Development

No branches or pull requests

3 participants