[pkg/ottl] Support Minute/Day/Month/Year for time.Time's in OTTL #33106
Labels
Comments
sinkingpoint
added
enhancement
|
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
TylerHelmuth
added
priority:p2
This was referenced May 20, 2024
TylerHelmuth
pushed a commit
that referenced
this issue
May 22, 2024
**Description:** This adds in a `Year` converter that takes a `time.Time` and returns the int month component. Analogous to what we already have with `Hour` **Link to tracking Issue:** #33106 **Testing:** Added two unit tests based on the existing `Hour` ones **Documentation:** Added the new converter to the ottlfuncs README.md --------- Signed-off-by: sinkingpoint <colin@quirl.co.nz>
TylerHelmuth
pushed a commit
that referenced
this issue
May 22, 2024
**Description:** This adds in a `Month` converter that takes a `time.Time` and returns the int month component. Analogous to what we already have with `Hour` **Link to tracking Issue:** #33106 **Testing:** Added two unit tests based on the existing `Hour` ones **Documentation:** Added the new converter to the ottlfuncs README.md --------- Signed-off-by: sinkingpoint <colin@quirl.co.nz>
evan-bradley
added a commit
that referenced
this issue
May 22, 2024
**Description:** This adds in a `Day` converter that takes a `time.Time` and returns the int day component. Analogous to what we already have with `Hour` **Link to tracking Issue:** #33106 **Testing:** Added two unit tests based on the existing `Hour` ones **Documentation:** Added the new converter to the ottlfuncs README.md --------- Signed-off-by: sinkingpoint <colin@quirl.co.nz> Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com> Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com>
|
@sinkingpoint do you want to do one more for |
|
Yep! #33200 |
evan-bradley
pushed a commit
that referenced
this issue
May 28, 2024
**Description:** This adds in a Minute converter that takes a time.Time and returns the int minute component. Analogous to what we already have with Hour **Link to tracking Issue:** #33106 **Testing:** Added two unit tests based on the existing Hour ones **Documentation:** Added the new converter to the ottlfuncs README.md --------- Signed-off-by: sinkingpoint <colin@quirl.co.nz> Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Component(s)
pkg/ottl
Is your feature request related to a problem? Please describe.
Under #29468 we currently support
Houras a method to get the Hour from a time.Time , but we don't support any other converters to get the other components of the time.Specifically, I want the day/month/year so that I can use the new grouping support in the file exporter to output "$day/$month/$year.log" files
Describe the solution you'd like
We should fill in the other components, mapping to the
Minute,Day,Month, andYearmethods that go supports ontime.TimesDescribe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: