Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove source duplication to build Windows MSI #575

Open
pjanotti opened this issue Jun 11, 2024 · 0 comments
Open

Remove source duplication to build Windows MSI #575

pjanotti opened this issue Jun 11, 2024 · 0 comments

Comments

@pjanotti
Copy link
Contributor

pjanotti commented Jun 11, 2024 •
edited
Loading

The windows-installer.wxs and opentelemetry.ico are duplicated on the otelcol and otelcol-contrib folders, they are exactly the same. We should look at generating at least the wxs file, either in this repo or by adding it as an option to the builder, to avoid this duplication.

Related:
@pjanotti pjanotti mentioned this issue Jun 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pjanotti