[exporterhelper] Adding shutdown & startup debug logs for retry, queue, and batch sender #10208
Conversation
timannguyen
force-pushed
the
sender-logging-10201
branch
from
8cd409a
to
822f427
Compare
timannguyen
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10208 +/- ##
=======================================
Coverage 91.99% 91.99%
=======================================
Files 361 361
Lines 16970 16980 +10
=======================================
+ Hits 15611 15621 +10
Misses 1021 1021
Partials 338 338 ☔ View full report in Codecov by Sentry. |
| qs.logger.Debug("Started Queue Sender", zap.String(obsmetrics.ExporterKey, qs.fullName), zap.Error(err)) | ||
| errs = multierr.Append(errs, err) |
There was a problem hiding this comment.
| qs.logger.Debug("Started Queue Sender", zap.String(obsmetrics.ExporterKey, qs.fullName), zap.Error(err)) | |
| errs = multierr.Append(errs, err) | |
| errs = multierr.Append(errs, err) | |
| qs.logger.Debug("Started Queue Sender", zap.String(obsmetrics.ExporterKey, qs.fullName), zap.Error(errs)) |
| @@ -91,6 +94,7 @@ func (bs *batchSender) Start(_ context.Context, _ component.Host) error { | |||
| } | |||
| }() | |||
|
|
|||
| bs.logger.Debug("Started Batch Sender", zap.String(obsmetrics.ExporterKey, bs.fullName)) | |||
There was a problem hiding this comment.
I think the obsmetrics.ExporterKey entry is not necessary, the logger will have a "name" entry (see https://github.com/open-telemetry/opentelemetry-collector/blob/main/service/internal/components/loggers.go#L38) with this.
There was a problem hiding this comment.
removed the exporter key from all the logs.
timannguyen
force-pushed
the
sender-logging-10201
branch
from
a2d50d4
to
8305715
Compare
timannguyen
changed the title
bogdandrutu
dismissed
their stale review
Removing blocking since the main issue was fixed, I still am not sure why we need this.
|
@bogdandrutu is there anything else i need to address? |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Description
Adding debug logs to starting and shutdown of batch, retry, and queue sender in exporterhelper to understand which component is stuck shutting down or starting up. This is added in order to improve debugging when one of these components are stuck shutting down or starting up.
Link to tracking issue
Fixes #10201
Testing
N/A
Documentation
N/A