Access to Collector Log Pointer is not atomic

[cpheps]

Describe the bug
Access to the collectors log pointer is not atomic. If GetLogger is called before Run the returned pointer is no longer valid as it is updated during startup.

It also presents a race condition between calling shutdown and run as shutdown could reference the pointer in the recover before or after it's set.

Steps to reproduce

1. Call GetLogger before Run
2. Call Run
3. Observe GetLogger is still using the noop logger

What did you expect to see?
If I call GetLogger before Run the pointer I'm given should update and log.

What did you see instead?
Log pointer is not atomic so GetLogger will return a different point before and after Run is called.

What version did you use?
v0.45.0

What config did you use?
Any will work

Environment
OS: MacOS 12.2.1
Compiler(if manually compiled): go 1.17.6

Additional Context

Action item from #4827

[patil-kshitij]

Can I start looking into this ?

[cpheps]

@patil-kshitij by all means. I might have capacity to do so until next week so feel free.

[dmitryax]

cc @djaglowski

[sakshi1215]

Hey @dmitryax @cpheps Can you please assign this issue to me, I would like to take a dig at this.

[dmitryax]

Thanks @sakshi1215. Assigned

[sakshi1215]

I was looking at this issue & have noticed that its no longer valid. Since version 0.54 we have remove the GetLogger method as well the Collector object no longer packagers Logger instance with it but only has LoggerOption under set.LoggingOptions
Reference:

opentelemetry-collector/service/collector.go

Line 74 in 06db057

set CollectorSettings

https://github.com/open-telemetry/opentelemetry-collector/blob/main/CHANGELOG.md#-breaking-changes--7

Can we close this @dmitryax & @cpheps ?

[dmitryax]

Thanks @sakshi1215. Closed