You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If we move this to consumer we'd be adding a direct dependency between confighttp/configgrpc and consumer, but I think thats ok. Considering the functionality within client exists to help share context between components I think this makes sense.
When we do the move we can expand some of the naming to include the keyword Connection. So Info could become ConnectionInfo, Addr becomes ConnectionAddr, Auth becomes ConnectionAuth, and Metadata becomes ConnectionMetadata. It is kinda verbose, but directly conveys what the struct represents. NewContext can potentially become NewContextWithConnectionInfo.
I would prefer not to restrict the Info struct to any specific component type. We don't restrict how components make connections, so I think it is valid for any component to be allowed to add its connection to the context and pass it own down the component pipeline. It should also be valid for any component to ask if there is an Info struct in the current ctx.
Originally posted by @bogdandrutu in #9805 (comment)
The text was updated successfully, but these errors were encountered: