Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logs SDK] Modify InstrumentationScope class #1690

Closed
lalitb opened this issue Oct 17, 2022 · 2 comments · Fixed by #2004
Closed

[Logs SDK] Modify InstrumentationScope class #1690

lalitb opened this issue Oct 17, 2022 · 2 comments · Fixed by #2004

Comments

@lalitb
Copy link
Member

lalitb commented Oct 17, 2022

Instrumentation class needs to be modified to store key-value attributes. This is required for storing the event_name and attributes passed through LoggerProvider::GetLogger() method.

This is also consistent with the OTLP proto specs-

https://github.com/open-telemetry/opentelemetry-proto/blob/1e69bf2e789665a56eed3a3e9cf4fd51ff784ab6/opentelemetry/proto/common/v1/common.proto#L71

@github-actions
Copy link

This issue was marked as stale due to lack of activity.

@github-actions github-actions bot added the Stale label Dec 17, 2022
@owent
Copy link
Member

owent commented Dec 19, 2022

Please don't stale this issue, I will continue finish left works when I have time.
Sorry, I only work on this in spare time and can not finish all changes in a short period of time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants