Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent namespace scope resolution #368

Closed
kxyr opened this issue Oct 18, 2020 · 4 comments
Closed

Consistent namespace scope resolution #368

kxyr opened this issue Oct 18, 2020 · 4 comments
Assignees
Labels
good first issue Good for newcomers priority:p2 Issues that are not blocking Stale

Comments

@kxyr
Copy link
Contributor

kxyr commented Oct 18, 2020

As suggested in this comment, the scope resolution usage should be consistent across all files. A convention should be established to use either opentelemetry::* or simplified to *. This should be done across all files and namespaces.

cc @alolita

@pyohannes pyohannes added the good first issue Good for newcomers label Oct 22, 2020
@kxyr kxyr changed the title Consistent scope resolution Consistent namespace scope resolution Dec 4, 2020
@lalitb lalitb added the priority:p2 Issues that are not blocking label Dec 16, 2020
@PaurushGarg
Copy link
Member

@lalitb @pyohannes : Can I please pick this issue. please assign this to me, I am working in @alolita team.
Tag @alolita

@lalitb
Copy link
Member

lalitb commented Sep 23, 2021

@PaurushGarg - yes this would be really good to fix. It would also be good to follow the namespace guidelines from here:
https://google.github.io/styleguide/cppguide.html#Namespaces
Basically

  • You may not use a using-directive to make all names from a namespace available.
  • Do not use Namespace aliases at namespace scope in header files except in explicitly marked internal-only namespaces, because anything imported into a namespace in a header file becomes part of the public API exported by that file.

Also in source files, we need to have consistent namespace alias names ( eg, trace_sdk, trace_api, nostd etc ).

@github-actions
Copy link

This issue was marked as stale due to lack of activity. It will be closed in 7 days if no furthur activity occurs.

@github-actions github-actions bot added the Stale label Nov 28, 2021
@github-actions
Copy link

github-actions bot commented Dec 5, 2021

Closed as inactive. Feel free to reopen if this is still an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers priority:p2 Issues that are not blocking Stale
Projects
None yet
Development

No branches or pull requests

4 participants