Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix condition always false in http_trace_context and create common utils file for propagators #539

Closed
TomRoSystems opened this issue Jan 28, 2021 · 2 comments
Closed

Fix condition always false in http_trace_context and create common utils file for propagators #539

TomRoSystems opened this issue Jan 28, 2021 · 2 comments
Assignees
@TomRoSystems
Labels
bug Something isn't working

Comments

@TomRoSystems
Copy link
Member

Description
Bug was discovered during review #523 :
#523 (comment)

also move common stuff for http_trace_context.h and b3_propagator.h into one file.
@TomRoSystems TomRoSystems added the bug Something isn't working label Jan 28, 2021
@TomRoSystems
Copy link
Member Author

Please assing me to this issue.

@TomRoSystems TomRoSystems mentioned this issue Jan 28, 2021
Merged
@seemk
Copy link
Contributor

seemk commented Apr 7, 2021

I believe this can be closed now as this code was refactored out with #608

@lalitb lalitb closed this as completed Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TomRoSystems TomRoSystems

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lalitb @seemk @TomRoSystems