Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid FormatException #2039

Closed
Kielek opened this issue Jan 23, 2023 · 1 comment · Fixed by #2332
Closed

Avoid FormatException #2039

Kielek opened this issue Jan 23, 2023 · 1 comment · Fixed by #2332
Milestone
0.7.0

Comments

@Kielek
Copy link
Contributor

Kielek commented Jan 23, 2023 •
edited
Loading

OpenTelemetry SDK stops throwing FormatException when parameters for env.vars are not supported.
AutoInstrumentation should follow this pattern.

ref: open-telemetry/opentelemetry-dotnet#3690
@pjanotti pjanotti added this to the 1.0.0-rc milestone Jan 25, 2023
@pjanotti
Copy link
Contributor

SIG: update design doc to cover this behavior change.

@pellared pellared changed the title Avoid FormatException. Avoid FormatException Jan 25, 2023
@pellared pellared changed the title Avoid FormatException Avoid FormatException Jan 25, 2023
@Kielek Kielek modified the milestones: 1.0.0-rc, 0.7.0 Mar 16, 2023
@Kielek Kielek mentioned this issue Mar 16, 2023
Merged
1 task
@Kielek Kielek mentioned this issue Mar 17, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
OpenTelemetry .NET Automatic Instrumentation
Archived in project
Milestone
0.7.0
Development

Successfully merging a pull request may close this issue.

Avoid FormatException while parsing configuration Kielek/opentelemetry-dotnet-instrumentation
2 participants
@pjanotti @Kielek