Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DiagnosticSource instrumentations produce activities without ActivitySource. #1522

Closed
cijothomas opened this issue Nov 12, 2020 · 0 comments · Fixed by #1515
Closed

DiagnosticSource instrumentations produce activities without ActivitySource. #1522

cijothomas opened this issue Nov 12, 2020 · 0 comments · Fixed by #1515
Labels
bug Something isn't working
Milestone
1.0.0-RC1

Comments

@cijothomas
Copy link
Member

cijothomas commented Nov 12, 2020 •
edited
Loading

Activities created outside ActivitySource API (i.e DiagnosticSource APIs) has a default ActivitySource with name as string.Empty. ActivitySource is the instrumentationlibrary information, which would be missing for those activities.
There is no easy fix, other than to use reflection and set Activity.ActivitySource.

#19 (comment)
@cijothomas cijothomas added the bug Something isn't working label Nov 12, 2020
@cijothomas cijothomas added this to the 1.0.0-RC1 milestone Nov 12, 2020
@eddynaka eddynaka mentioned this issue Nov 12, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.0.0-RC1
Development

Successfully merging a pull request may close this issue.

Fixing ActivitySource from DiagnosticSource
1 participant
@cijothomas