Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove public extension methods on Activity not required for functionality/spec #1544

Closed
cijothomas opened this issue Nov 14, 2020 · 0 comments · Fixed by #1545
Closed

Remove public extension methods on Activity not required for functionality/spec #1544

cijothomas opened this issue Nov 14, 2020 · 0 comments · Fixed by #1545
Assignees
@cijothomas
Labels
bug Something isn't working

Comments

@cijothomas
Copy link
Member

Some methods like GetStatus,RecordException are by-design public APIs as it is serving spec needs.
There are a large number of extensions on Activity (eg: GetTag) which are special implementations to avoid allocations. These must not be made public.
For reuse within the repo, copy paste or use shared files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cijothomas cijothomas

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Mark Activity extension methods not required by spec as internal open-telemetry/opentelemetry-dotnet
1 participant
@cijothomas