-
Notifications
You must be signed in to change notification settings - Fork 734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix prometheus exporter to handle histogram with no buckets #2651
Merged
cijothomas
merged 7 commits into
open-telemetry:main
from
cijothomas:cijothomas/prometheushistoramnullref
Nov 21, 2021
Merged
Fix prometheus exporter to handle histogram with no buckets #2651
cijothomas
merged 7 commits into
open-telemetry:main
from
cijothomas:cijothomas/prometheushistoramnullref
Nov 21, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2651 +/- ##
==========================================
+ Coverage 81.31% 81.33% +0.01%
==========================================
Files 245 246 +1
Lines 8645 8659 +14
==========================================
+ Hits 7030 7043 +13
- Misses 1615 1616 +1
|
CodeBlanch
reviewed
Nov 20, 2021
src/OpenTelemetry.Exporter.Prometheus/Implementation/PrometheusSerializerExt.cs
Outdated
Show resolved
Hide resolved
CodeBlanch
approved these changes
Nov 20, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
reyang
approved these changes
Nov 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #.
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes