Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prometheus exporter to handle histogram with no buckets #2651

Merged

Conversation

cijothomas
Copy link
Member

Fixes #.

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

@cijothomas cijothomas requested a review from a team as a code owner November 20, 2021 17:26
@codecov
Copy link

codecov bot commented Nov 20, 2021

Codecov Report

Merging #2651 (9e3d78d) into main (31a2d67) will increase coverage by 0.01%.
The diff coverage is 94.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2651      +/-   ##
==========================================
+ Coverage   81.31%   81.33%   +0.01%     
==========================================
  Files         245      246       +1     
  Lines        8645     8659      +14     
==========================================
+ Hits         7030     7043      +13     
- Misses       1615     1616       +1     
Impacted Files Coverage Δ
...tryProtocol/Implementation/MetricItemExtensions.cs 50.00% <42.85%> (-0.71%) ⬇️
...ometheus/Implementation/PrometheusSerializerExt.cs 100.00% <100.00%> (ø)
src/OpenTelemetry/Metrics/MetricPoint.cs 90.51% <100.00%> (-0.24%) ⬇️
src/OpenTelemetry/ReadOnlyTagCollection.cs 100.00% <100.00%> (ø)
...ter.ZPages/Implementation/ZPagesActivityTracker.cs 97.14% <0.00%> (-2.86%) ⬇️

Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cijothomas cijothomas merged commit 1b9ec94 into open-telemetry:main Nov 21, 2021
@cijothomas cijothomas deleted the cijothomas/prometheushistoramnullref branch November 21, 2021 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants