Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SetHttpFlavor option from httpclient instrumentations #3380

Closed
cijothomas opened this issue Jun 17, 2022 · 0 comments · Fixed by #3381
Closed

Remove SetHttpFlavor option from httpclient instrumentations #3380

cijothomas opened this issue Jun 17, 2022 · 0 comments · Fixed by #3381

Comments

@cijothomas
Copy link
Member

cijothomas commented Jun 17, 2022

Related to #3373

HttpClient instrumentations current have an option SetHttpFlavor which determines if 'http.flavor' is populated or not. This, I believe, was added in early days of instrumentation, when this was the only tag that was optional. Conventions have grown significantly since then, so maintaining on/off flag for each of them would be impractical.

'http.flavor' is listed as Recommended in the Spec, so it should be populated by default. SDK may provide an option to turn it off.

Given the fact that this tag's value is readily available, and is a Recommended tag, proposing to remove this On/Off option.
If any user does not want this tag, they may remove it by doing activity.SetTag("http.flavor", null) with an ActivityProcessor.

As part of overall issue tracked by #3373, we can consider exposing on/off flags in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant