Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prometheus exporter: counters should have _total suffix #3973

Closed
dashpole opened this issue Dec 6, 2022 · 2 comments
Closed

Prometheus exporter: counters should have _total suffix #3973

dashpole opened this issue Dec 6, 2022 · 2 comments
Labels
enhancement New feature or request pkg:OpenTelemetry.Exporter.Prometheus.AspNetCore Issues related to OpenTelemetry.Exporter.Prometheus.AspNetCore NuGet package

Comments

@dashpole
Copy link

dashpole commented Dec 6, 2022

From the Prometheus spec for sums:

Monotonic Sum metric points MUST have _total added as a suffix to the metric name.

The current implementation does not add this suffix to the metric name.
@dashpole dashpole added the enhancement New feature or request label Dec 6, 2022
@cijothomas cijothomas added the pkg:OpenTelemetry.Exporter.Prometheus.AspNetCore Issues related to OpenTelemetry.Exporter.Prometheus.AspNetCore NuGet package label Jan 13, 2023
@dashpole dashpole mentioned this issue Jun 26, 2023
Open
@marcinjahn
Copy link

marcinjahn commented Feb 15, 2024 •
edited

Currently, the Prometheus Exporter adds _total to counters.

From the specs:

Exporters SHOULD provide a configuration option to disable the addition of _total suffixes.

There is no such option :|

@reyang
Copy link
Member

reyang commented May 21, 2024

Covered by #4753.

@reyang reyang closed this as completed May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request pkg:OpenTelemetry.Exporter.Prometheus.AspNetCore Issues related to OpenTelemetry.Exporter.Prometheus.AspNetCore NuGet package
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dashpole @cijothomas @marcinjahn @reyang