Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default value for simple exemplar reservoir size #4803

Conversation

utpilla
Copy link
Contributor

@utpilla utpilla commented Aug 25, 2023

Spec has provided a default value for SimpleExemplarReservoir size: open-telemetry/opentelemetry-specification#3670

Changes

  • Update the default size for SimpleExemplarReservoir to 1.

Merge requirement checklist

  • Appropriate CHANGELOG.md files updated for non-trivial changes

@utpilla utpilla requested a review from a team as a code owner August 25, 2023 23:53
@codecov
Copy link

codecov bot commented Aug 26, 2023

Codecov Report

Merging #4803 (7852f81) into main (d0d9133) will increase coverage by 0.05%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4803      +/-   ##
==========================================
+ Coverage   83.46%   83.52%   +0.05%     
==========================================
  Files         292      292              
  Lines       11987    11987              
==========================================
+ Hits        10005    10012       +7     
+ Misses       1982     1975       -7     
Files Changed Coverage Δ
src/OpenTelemetry/Metrics/MetricPoint.cs 61.79% <ø> (ø)

... and 4 files with indirect coverage changes

@@ -5,6 +5,9 @@
* Increased the character limit of the Meter instrument name from 63 to 255.
([#4774](https://github.com/open-telemetry/opentelemetry-dotnet/issues/4774))

* Update default size for `SimpleExemplarReservoir` to `1`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

@utpilla utpilla Aug 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine to not add this. It should be okay to add this only when introducing a public API change.

@utpilla utpilla merged commit 6570696 into open-telemetry:main Aug 28, 2023
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants