Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose ot_tracer record? #75

Closed
garthk opened this issue Apr 17, 2020 · 2 comments
Closed

Expose ot_tracer record? #75

garthk opened this issue Apr 17, 2020 · 2 comments

Comments

@garthk
Copy link
Contributor

garthk commented Apr 17, 2020

I can't try on_start_processors and on_end_processors in a unit test to solve #73 without being able to call :opentelemetry.set_default_tracer/1 with a #tracer{}, which I can't consume with Record.extract/2 because it's not in include.

That's not entirely true. I can save the environment, replace it, stop the app, restart it, run my test, stop it again, put back the old environment, and restart it again. You'll feel awful when you review the code, though.

@tsloughter
Copy link
Member

You need this accessible in another repo?

When it is just for a test the usual process is to include the header even if it isn't in the include directory.

@garthk
Copy link
Contributor Author

garthk commented Apr 24, 2020

Yeah, I'll work around it. :/

@garthk garthk closed this as completed Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants