Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change OTEL_TARGET_EXE to OTEL_GO_AUTO_TARGET_EXE #97

Merged
merged 5 commits into from
Apr 26, 2023
Merged

Change OTEL_TARGET_EXE to OTEL_GO_AUTO_TARGET_EXE #97

merged 5 commits into from
Apr 26, 2023

Conversation

pellared
Copy link
Member

Fixes #96

@pellared
Copy link
Member Author

Needs #95 😉

@pellared pellared marked this pull request as ready for review April 26, 2023 07:40
@pellared pellared requested a review from a team as a code owner April 26, 2023 07:40
@pdelewski
Copy link
Member

LGTM, however I'm thinking whether TARGET_EXE is best name for this variable

@pellared
Copy link
Member Author

LGTM, however I'm thinking whether TARGET_EXE is best name for this variable

We can change it if you have a better proposal. However, I would prefer to tackle it in a separate PR. This PR is about using the OTEL_GO_AUTO_ prefix.

@pdelewski
Copy link
Member

@pellared Agree, prefix fullfil spec requirements.

@pdelewski pdelewski mentioned this pull request Apr 26, 2023
Closed
MikeGoldsmith
MikeGoldsmith approved these changes Apr 26, 2023
View reviewed changes
Copy link
Member

@MikeGoldsmith MikeGoldsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pellared 👍🏻

@MikeGoldsmith
Copy link
Member

@pellared #95 has merged, this can be rebased on now 😄

@MrAlias MrAlias merged commit 3e35cba into open-telemetry:main Apr 26, 2023
7 checks passed
@pellared pellared deleted the rename-target-exe branch April 26, 2023 15:20
@MrAlias MrAlias mentioned this pull request May 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeGoldsmith MikeGoldsmith MikeGoldsmith approved these changes

@MrAlias MrAlias MrAlias approved these changes

@pdelewski pdelewski pdelewski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change OTEL_TARGET_EXE to OTEL_GO_AUTO_TARGET_EXE
4 participants
@pellared @pdelewski @MikeGoldsmith @MrAlias