-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prometheus exemplar example #96
Conversation
890d325
to
412fcb0
Compare
412fcb0
to
a5b9368
Compare
I fixed the example by moving the Now, the only problem i'm facing is that the value of the exemplar seems to be recorded incorrectly. All iterations are about 1000 milliseconds long, which can be seen in the histogram. All observations fall into the |
Using the logging exporter, I can confirm that it isn't an issue with the prometheus exporter:
The values of both are 0.0, even though only higher buckets have any observations. |
a5b9368
to
073d939
Compare
Even though exemplar recording isn't currently working, I think this example is now correct, and should work after that is fixed. I consider this ready for review. |
prometheus/src/main/java/io/opentelemetry/example/prometheus/ExampleConfiguration.java
Outdated
Show resolved
Hide resolved
prometheus/src/main/java/io/opentelemetry/example/prometheus/PrometheusExample.java
Show resolved
Hide resolved
prometheus/src/main/java/io/opentelemetry/example/prometheus/PrometheusExample.java
Outdated
Show resolved
Hide resolved
926bd43
to
3a219a8
Compare
(sorry, tests are passing now) |
thx! |
Add an example of using the prometheus exporter to produce prometheus exemplars.
This PR does the following:
If I curl the endpoint using OpenMetrics, I can see exemplars
curl -H 'Accept: application/openmetrics-text; version=1.0.0; charset=utf-8' http://localhost:19090/metrics
The associated trace for the exemplar:
cc @jsuereth