Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set net peer for gRPC client #1338

Closed
anuraaga opened this issue Oct 7, 2020 · 4 comments
Closed

Set net peer for gRPC client #1338

anuraaga opened this issue Oct 7, 2020 · 4 comments

Comments

@anuraaga
Copy link
Contributor

anuraaga commented Oct 7, 2020

When separating out library instrumentation from auto, we removed an auto-specific workaround for setting net peer. Clients should provide the net peer in general, and gRPC does do so with an "ExperimentalApi". Going to dig for ways without that, or to find a way with the existing APIs, before requiring users to pass in the net peer themselves.

#1329 (comment)

@mateuszrzeszutek
Copy link
Member

net.peer.* attributes are now added by GrpcNetAttributesExtractor -- peer.service was still missing though, will be added in #3357

@ralphgj
Copy link
Contributor

ralphgj commented Jan 19, 2022

Hi, I used agent of v1.10.0 and then I found the grpc client spans don't capture the attributes of net.peer. But in this issue, it seems being already resolved.
I use the grpc-java examples as the demo.

@trask
Copy link
Member

trask commented Jan 19, 2022

hi @ralphgj, can you open a new issue for this? thx!

@ralphgj
Copy link
Contributor

ralphgj commented Jan 20, 2022

hi @ralphgj, can you open a new issue for this? thx!

yeah, I will do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants