-
Notifications
You must be signed in to change notification settings - Fork 796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set net peer for gRPC client #1338
Comments
|
Hi, I used agent of v1.10.0 and then I found the grpc client spans don't capture the attributes of |
hi @ralphgj, can you open a new issue for this? thx! |
yeah, I will do it. |
When separating out library instrumentation from auto, we removed an auto-specific workaround for setting net peer. Clients should provide the net peer in general, and gRPC does do so with an "ExperimentalApi". Going to dig for ways without that, or to find a way with the existing APIs, before requiring users to pass in the net peer themselves.
#1329 (comment)
The text was updated successfully, but these errors were encountered: