Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize DB query normalizer property names #1431

Closed
mateuszrzeszutek opened this issue Oct 20, 2020 · 2 comments · Fixed by #1509
Closed

Standardize DB query normalizer property names #1431

mateuszrzeszutek opened this issue Oct 20, 2020 · 2 comments · Fixed by #1509
Assignees

Comments

@mateuszrzeszutek
Copy link
Member

Right now we only have one property for SQL (JDBC): sql.normalizer.enabled. How about renaming it to something like otel.query.normalizer.<db>.enabled, otel.<db>.query.normalizer.enabled? We could use separate config properties for each query normalizer that's used in the agent (enabled by default).

Regarding the <db> placeholder: should we use the DbSystem name or the query language name (sql, cql, n1ql, ...)? I think it makes more sense to disable per query language, but on the other hand it introduces a new concept/dimension (you have to know which instrumentation/DbSystem uses which language).

@trask
Copy link
Member

trask commented Oct 20, 2020

Does it work to conform to otel.instrumentation.<instrumentationid>.* proposed in #1414?

E.g. otel.instrumentation.jdbc.query.normalizer.enabled

@mateuszrzeszutek
Copy link
Member Author

Hmm, that sounds good. The only "problem" that I can think of is with Redis, which has multiple instrumentations - but I believe that if for some reason you want to disable sanitization then you probably know which Redis library you're using.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants