Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smoke tests with Jaeger and Zipkin #1541

Closed
iNikem opened this issue Nov 2, 2020 · 4 comments · Fixed by #1543
Closed

Smoke tests with Jaeger and Zipkin #1541

iNikem opened this issue Nov 2, 2020 · 4 comments · Fixed by #1543
Labels
area:tests enhancement New feature or request
Projects
GA

Comments

@iNikem
Copy link
Contributor

iNikem commented Nov 2, 2020

Our Roadmap says that we want "End-to-end tests with OTLP, Jaeger and Zipkin". Currently only OTLP is implemented, Jaeger and Zipkin should be added.

@anuraaga this means either reverting #1136 or introducing Collector between tests and fake backend. Any suggestions or preferences?
@anuraaga
Copy link
Contributor

anuraaga commented Nov 2, 2020

There isn't any OTLP open source backend so we have a fake backend for it, but we can start Zipkin and Jaeger easily with testcontainers and use their standard query APIs. I guess we don't need to revert nor introduce collector for them right?

@iNikem
Copy link
Contributor Author

iNikem commented Nov 2, 2020

Mmmm, I am not sure I want to bring any infrastructure outside of Otel into these tests. But this depends on what we actually mean by that goal on our Roadmap. If it is "we want to be able to export Zipkin to any Zipkin-compliant backend", then probably it is right thing to do...

@iNikem iNikem added this to To do in GA Nov 2, 2020
@iNikem
Copy link
Contributor Author

iNikem commented Nov 2, 2020

Wait, we already have Collector in our tests :D

@iNikem iNikem mentioned this issue Nov 2, 2020
Merged
@trask
Copy link
Member

trask commented Nov 2, 2020

Wait, we already have Collector in our tests :D

That was convenient 😄

GA automation moved this from To do to Done Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:tests enhancement New feature or request
Projects
No open projects
GA
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Smoke tests using Jaeger and Zipkin exporters iNikem/opentelemetry-java-instrumentation
3 participants
@anuraaga @trask @iNikem