Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support non-uber jar releases of mongo-java-driver #1588

Closed
jyemin opened this issue Nov 9, 2020 · 4 comments
Closed

Support non-uber jar releases of mongo-java-driver #1588

jyemin opened this issue Nov 9, 2020 · 4 comments
Labels
enhancement New feature or request

Comments

@jyemin
Copy link
Contributor

jyemin commented Nov 9, 2020

Is your feature request related to a problem? Please describe.
Starting with the 4.0 release of the MongoDB Java driver, the mongo-java-driver uber-jar module is no longer included in the distribution. I think this will cause problems given that the muzzle configuration for the driver only references mongo-java-driver.

Even before 4.0, non-uber jars have also been published, and if I understand correctly anyone using those jars would not get the benefits provided by muzzle (which I don't fully understand).

Describe the solution you'd like

Support instrumentation with the non-uber jar modules of the MongoDB Java driver

From 3.7 on, MongoClientSettings is included in the mongodb-driver-core module.

From 3.9 on, MongoClientOptions is included in the mongodb-driver-legacy module.

Describe alternatives you've considered
None

Additional context
None

@jyemin jyemin added the enhancement New feature or request label Nov 9, 2020
@trask
Copy link
Member

trask commented Nov 12, 2020

Thanks!

Luckily our sibling project just added Mongo driver v4 support DataDog/dd-trace-java#2043, looks like we need to merge that over to this repo.

For some light reading on muzzle that won't answer all of your questions 😄, see https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/master/docs/contributing/muzzle.md

@malafeev
Copy link
Contributor

@trask I would like to merge Mongo driver v4 support

@malafeev
Copy link
Contributor

PR: #2046

@trask
Copy link
Member

trask commented Apr 6, 2021

I believe this is closed by #2046

@trask trask closed this as completed Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants