Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not mapped requests should be instrumented as HTTP {method} #2355

Closed
anuraaga opened this issue Feb 20, 2021 · 1 comment
Closed

Not mapped requests should be instrumented as HTTP {method} #2355

anuraaga opened this issue Feb 20, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@anuraaga
Copy link
Contributor

Currently our HttpServerTest verifies that the span name for a not found request is the request path. As the request was not actually mapped, there is no route to match it against so this can only be achieved with a high cardinality name using the path directly. I think we usually want to use the method for such cases.

This should only apply to unmapped requests - if a handler accepted it and returned 404 explicitly (e.g. a request with a path param for an Id that didn't exist in the db) it should still use the route.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants