Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should ReactorAsyncSpanEndStrategy end the span on cancellation? #3152

Closed
trask opened this issue May 31, 2021 · 3 comments
Closed

Should ReactorAsyncSpanEndStrategy end the span on cancellation? #3152

trask opened this issue May 31, 2021 · 3 comments

Comments

@trask
Copy link
Member

trask commented May 31, 2021

Similar to #3150

cc: @HaloFour
@HaloFour
Copy link
Contributor

HaloFour commented May 31, 2021 •
edited
Loading

Oo, good question. I honestly thought that was picked up by doOnError but it apparently isn't. Should be an easy fix, and likely applies to the RxJava implementations as well (confirmed). Question is would a cancelled subscription be considered a successful or failed span?

For the sake of discussion I'll start putting together a PR that will handle cancellation for Reactor, RxJava 2 and RxJava 3. I'll have it set the status of the span to Error with a CancellationException.

@HaloFour
Copy link
Contributor

See: #3153

@trask
Copy link
Member Author

trask commented Jun 3, 2021

Closed by #3153. Thanks @HaloFour!

@trask trask closed this as completed Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@trask @HaloFour