Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory leak in FieldBackedProvider #3294

Closed
nyilmaz opened this issue Jun 14, 2021 · 4 comments
Closed

Memory leak in FieldBackedProvider #3294

nyilmaz opened this issue Jun 14, 2021 · 4 comments
Labels
bug Something isn't working

Comments

@nyilmaz
Copy link

nyilmaz commented Jun 14, 2021

While using kinesis-logback-appender we come up with oom failures in our production applications. When we investigate heapdump, here what we found:

image

Seems FieldBackedProvider holds all request contexts of aws sdk's netty http client.

Also I reproduced the issue with my local environment.

logback config:

<appender name="KINESIS" class="com.gu.logback.appender.kinesis.FirehoseAppender">
    <bufferSize>1000</bufferSize>
    <threadCount>10</threadCount>
    <region>eu-west-1</region>
    <maxRetries>3</maxRetries>
    <shutdownTimeout>30</shutdownTimeout>
    <streamName>${STREAM_NAME}</streamName>
    <encoding>UTF-8</encoding>
  </appender>

opentelemetry version: 1.2.0

jvm params (result is the same with 256m Xmx):

-Xms256m
-Xmx2G
-XX:MetaspaceSize=128m
-XX:MaxMetaspaceSize=256m
-javaagent:/otel.jar
-Dotel.exporter.otlp.endpoint=http://main-collector.opentelemetry-operator-system.svc.cluster.local.:55690
-Dotel.resource.attributes=service.version=$APP_GIT_VERSION
-Dio.opentelemetry.javaagent.slf4j.simpleLogger.logFile=System.out

jvm:

openjdk version "16.0.1" 2021-04-20
OpenJDK Runtime Environment AdoptOpenJDK-16.0.1+9 (build 16.0.1+9)
OpenJDK 64-Bit Server VM AdoptOpenJDK-16.0.1+9 (build 16.0.1+9, mixed mode, sharing)

Container:

NAME="Alpine Linux"
ID=alpine
VERSION_ID=3.12.7
PRETTY_NAME="Alpine Linux v3.12"
HOME_URL="https://alpinelinux.org/"
BUG_REPORT_URL="https://bugs.alpinelinux.org/"
@nyilmaz nyilmaz added the bug Something isn't working label Jun 14, 2021
@laurit
Copy link
Contributor

laurit commented Jun 14, 2021

Should be fixed in #3059

@nyilmaz
Copy link
Author

nyilmaz commented Jun 14, 2021

Thanks @laurit , i missed that PR. Closing..

@nyilmaz nyilmaz closed this as completed Jun 14, 2021
@nyilmaz
Copy link
Author

nyilmaz commented Jun 14, 2021

@laurit any schedule for next version?

@mateuszrzeszutek
Copy link
Member

We're planning to release it early this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants