Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove continuation feature #48

Closed
trask opened this issue Jan 6, 2020 · 0 comments · Fixed by #49
Closed

Remove continuation feature #48

trask opened this issue Jan 6, 2020 · 0 comments · Fixed by #49
Milestone

Comments

@trask
Copy link
Member

trask commented Jan 6, 2020

Continuations automatically keep the local root span open until all nested spans are finished, e.g. the duration of the trace below would be ~1 second, instead of the ~1 millisecond that it takes to return from the method.

@Trace
public Future<String> execute() {
    activeScope().setAsyncPropagation(true); // enables continuation support for this trace
    return executor.submit(() -> {
        Thread.sleep(1000);
        return "Hello!";
    });
}

It's a nice feature, but also brings significant complexity, so I think it's worth removing.

Also, there's no equivalent OpenTelemetry API feature, so this would require a special agent API, and then instrumentation that relied on this would further diverge from manual (contrib) instrumentation.

@trask trask added this to the v0.1.0 milestone Jan 6, 2020
@trask trask closed this as completed in #49 Jan 8, 2020
@trask trask changed the title Remove continuation support Remove continuation feature Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant