You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
According to the spec for Semantic conventions for AWS SDK, the following attributes are expected for aws-sdk spans: rpc.method, rpc.service, rpc.system.
Steps to reproduce
Just run the instrumentation, or browse the code.
What did you expect to see?
I expected these attributes to be published by the aws-sdk 1.11 and aws-sdk 2.2 instrumentation according to the spec.
What did you see instead?
These attributes are published under different, non-spec attributes which are available only in experimental mode: aws.operation and aws.service
What version are you using?
latest 1.10.0
Additional context
I want to suggest renaming these attributes so they are spec-compliant and to always report them (not only when otel.instrumentation.aws-sdk.experimental-span-attributes is true).
If it makes sense, I can work on PR to do that.
The text was updated successfully, but these errors were encountered:
Thanks @blumamir! The collector has been updated to support the rpc.* attributes so it's safe to change our instrumentation to replace the non-spec attributes with spec attributes. If you're able to help with a PR that'd be great
Describe the bug
According to the spec for Semantic conventions for AWS SDK, the following attributes are expected for aws-sdk spans:
rpc.method
,rpc.service
,rpc.system
.Steps to reproduce
Just run the instrumentation, or browse the code.
What did you expect to see?
I expected these attributes to be published by the aws-sdk 1.11 and aws-sdk 2.2 instrumentation according to the spec.
What did you see instead?
These attributes are published under different, non-spec attributes which are available only in experimental mode:
aws.operation
andaws.service
What version are you using?
latest
1.10.0
Additional context
I want to suggest renaming these attributes so they are spec-compliant and to always report them (not only when
otel.instrumentation.aws-sdk.experimental-span-attributes
is true).If it makes sense, I can work on PR to do that.
The text was updated successfully, but these errors were encountered: