Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-sdk instrumentation is missing the RPC attributes from specification #5159

Closed
blumamir opened this issue Jan 17, 2022 · 2 comments · Fixed by #5166
Closed

aws-sdk instrumentation is missing the RPC attributes from specification #5159

blumamir opened this issue Jan 17, 2022 · 2 comments · Fixed by #5166
Assignees
Labels
bug Something isn't working

Comments

@blumamir
Copy link
Member

blumamir commented Jan 17, 2022

Describe the bug
According to the spec for Semantic conventions for AWS SDK, the following attributes are expected for aws-sdk spans: rpc.method, rpc.service, rpc.system.

Steps to reproduce
Just run the instrumentation, or browse the code.

What did you expect to see?
I expected these attributes to be published by the aws-sdk 1.11 and aws-sdk 2.2 instrumentation according to the spec.

What did you see instead?
These attributes are published under different, non-spec attributes which are available only in experimental mode: aws.operation and aws.service

What version are you using?
latest 1.10.0

Additional context
I want to suggest renaming these attributes so they are spec-compliant and to always report them (not only when otel.instrumentation.aws-sdk.experimental-span-attributes is true).
If it makes sense, I can work on PR to do that.

@blumamir blumamir added the bug Something isn't working label Jan 17, 2022
@anuraaga
Copy link
Contributor

Thanks @blumamir! The collector has been updated to support the rpc.* attributes so it's safe to change our instrumentation to replace the non-spec attributes with spec attributes. If you're able to help with a PR that'd be great

@blumamir
Copy link
Member Author

Hi @anuraaga , Thanks for taking a look.
I would like to work on it, can you please assign it to me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants