Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Cassandra instrumentation tests on all Java versions (not only Java 8) #552

Closed
trask opened this issue Jun 20, 2020 · 6 comments
Closed
Labels
area:tests contribution welcome Request makes sense, maintainers probably won't have time, contribution would be welcome

Comments

@trask
Copy link
Member

trask commented Jun 20, 2020

Currently, during the Cassandra instrumentation tests, Cassandra itself is run embedded in the JVM via Cassandra Unit, which limits us to using Java 8 for those instrumentation tests.

Instead, it would be nice to run Cassandra in a container, which would then allow us to test Cassandra instrumentation against all Java versions.

Being able to run external containers would probably be useful for other instrumentation tests as well (e.g. Mongo, Elasticsearch, Couchbase, Redis), instead of the ad-hoc wrappers that are used for each one today.

@trask trask added contribution welcome Request makes sense, maintainers probably won't have time, contribution would be welcome area:tests labels Jun 20, 2020
@iNikem
Copy link
Contributor

iNikem commented Jun 21, 2020

Unless there is a very good reason for doing otherwise, I prefer using Testcontainers instead of externally runs containers.

@trask
Copy link
Member Author

trask commented Jun 22, 2020

Testcontainers requires Java 8+ ☹️.

What do you think about abandoning Java 7 for instrumentation tests, and only validating Java 7 compatibility via (more limited) smoke tests (#298)?

@devinsba
Copy link
Contributor

If someone gets this working I'd be so happy to upstream this change into the DD code base. I gave it a short try one afternoon but haven't had the time otherwise

@iNikem
Copy link
Contributor

iNikem commented Jun 22, 2020

Testcontainers requires Java 8+ ☹️.

What do you think about abandoning Java 7 for instrumentation tests, and only validating Java 7 compatibility via (more limited) smoke tests (#298)?

Otel-java has done that. It is very tempting, especially for a person thinking that we should drop java 7 compatibility completely :)

@trask
Copy link
Member Author

trask commented Jun 23, 2020

I added the topic to this week's meeting agenda

@mateuszrzeszutek
Copy link
Member

Done in #1427

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:tests contribution welcome Request makes sense, maintainers probably won't have time, contribution would be welcome
Projects
None yet
Development

No branches or pull requests

4 participants