Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable span suppression by type (SpanKey) by default #5735

Closed
mateuszrzeszutek opened this issue Apr 1, 2022 · 1 comment · Fixed by #5779
Closed

Enable span suppression by type (SpanKey) by default #5735

mateuszrzeszutek opened this issue Apr 1, 2022 · 1 comment · Fixed by #5779
Assignees
Labels
enhancement New feature or request

Comments

@mateuszrzeszutek
Copy link
Member

#3691 introduced the more flexible, "by type" span suppression - it is still turned off by default (code), even though the spec allows nested CLIENT/PRODUCER span kinds (link).
Should we turn this behavior on by default? Recently there's been some progress on the instrumentation-api stability front, and we have to decide what we're going to do with this feature if we want to release a stable version. Personally, I believe that this should be on by default - since it very much makes sense to emit multiple spans of the same kind if they describe different aspects (conventions) of an operation.

@mateuszrzeszutek mateuszrzeszutek added the enhancement New feature or request label Apr 1, 2022
@mateuszrzeszutek mateuszrzeszutek added this to To do in Stable instrumentation-api via automation Apr 1, 2022
@trask
Copy link
Member

trask commented Apr 1, 2022

I support enabling it by default.

cc @lmolkova

@mateuszrzeszutek mateuszrzeszutek self-assigned this Apr 7, 2022
@mateuszrzeszutek mateuszrzeszutek moved this from To do to In progress in Stable instrumentation-api Apr 7, 2022
@mateuszrzeszutek mateuszrzeszutek moved this from In progress to Review in progress in Stable instrumentation-api Apr 14, 2022
Stable instrumentation-api automation moved this from Review in progress to Done Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants