Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move WithSpan annotation to this repository #6245

Closed
trask opened this issue Jun 30, 2022 · 3 comments
Closed

Move WithSpan annotation to this repository #6245

trask opened this issue Jun 30, 2022 · 3 comments

Comments

@trask
Copy link
Member

trask commented Jun 30, 2022

As discussed in SIG meetings and in open-telemetry/opentelemetry-java#4260.

What do you think of:

  • opentelemetry-instrumentation-annotations
  • Rename opentelemetry-instrumentation-api-annotation-support to opentelemetry-instrumentation-annotations-support

Another option is to keep the -api in the names:

  • opentelemetry-instrumentation-api-annotations
  • Keep current name of opentelemetry-instrumentation-api-annotation-support
@trask trask mentioned this issue Jun 30, 2022
Closed
@mateuszrzeszutek
Copy link
Member

What do you think of:

  • opentelemetry-instrumentation-annotations
  • Rename opentelemetry-instrumentation-api-annotation-support to opentelemetry-instrumentation-annotations-support

👍

@trask
Copy link
Member Author

trask commented Jun 30, 2022 •
edited

Steps:

  • Move instrumentation annotations to this repo #6248
  • Rename opentelemetry-instrumentation-api-annotation-support to opentelemetry-instrumentation-annotations-support
  • Add support in auto-instrumentation for the new package names (while maintaining support for the old package names)
  • Use new annotations in instrumentation tests
  • Update documentation to reference new annotations - will do after 1.17 release

@trask trask mentioned this issue Jun 30, 2022
Merged
This was referenced Jul 7, 2022
Merged
Merged
@trask trask mentioned this issue Jul 30, 2022
Merged
@jack-berg jack-berg mentioned this issue Aug 2, 2022
Merged
@mateuszrzeszutek
Copy link
Member

Done a while ago

@Emily-Jiang Emily-Jiang mentioned this issue Oct 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@trask @mateuszrzeszutek