Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snippet Injection add Smoke Test for reproducing Get ClassException #8707

Open
siyuniu-ms opened this issue Jun 13, 2023 · 1 comment
Open
Assignees
Labels
bug Something isn't working

Comments

@siyuniu-ms
Copy link
Contributor

siyuniu-ms commented Jun 13, 2023

In local test, got ClassCastException
warningjava.lang.ClassCastException: class io.opentelemetry.javaagent.instrumentation.servlet.snippet.InjectionState cannot be cast to class io.opentelemetry.javaagent.instrumentation.servlet.snippet.InjectionState (io.opentelemetry.javaagent.instrumentation.servlet.snippet.InjectionState is in unnamed module of loader org.apache.catalina.loader.ParallelWebappClassLoader @46f36c44; io.opentelemetry.javaagent.instrumentation.servlet.snippet.InjectionState is in unnamed module of loader java.net.URLClassLoader @644a3add)

Add a smoke test in OTEL to reproduce this problem.

@siyuniu-ms siyuniu-ms added the bug Something isn't working label Jun 13, 2023
@siyuniu-ms
Copy link
Contributor Author

The stack trace is as follows:
2023-06-13` 00:06:34.628Z DEBUG i.o.j.e.i.InstrumentationModule - Applying instrumentation: servlet [class io.opentelemetry.javaagent.instrumentation.servlet.v3_0.Servlet3InstrumentationModule] on ParallelWebappClassLoader
context: SnippetInjection
delegate: false
----------> Parent Classloader:
java.net.URLClassLoader@538a2f0e

2023-06-13 00:06:34.629Z DEBUG i.o.javaagent.tooling.HelperInjector - Injecting classes onto class loader ParallelWebappClassLoader
context: SnippetInjection
delegate: false
----------> Parent Classloader:
java.net.URLClassLoader@538a2f0e
-> [io.opentelemetry.javaagent.instrumentation.servlet.v3_0.Servlet3Singletons, io.opentelemetry.javaagent.instrumentation.servlet.snippet.OutputStreamSnippetInjectionHelper, io.opentelemetry.javaagent.instrumentation.servlet.v3_0.snippet.ServletOutputStreamInjectionState, io.opentelemetry.javaagent.instrumentation.servlet.snippet.InjectionState, io.opentelemetry.javaagent.instrumentation.servlet.snippet.SnippetInjectingResponseWrapper, io.opentelemetry.javaagent.instrumentation.servlet.ServletAccessor, io.opentelemetry.javaagent.instrumentation.servlet.ServletInstrumenterBuilder, io.opentelemetry.javaagent.instrumentation.servlet.common.response.ResponseInstrumenterFactory, io.opentelemetry.javaagent.instrumentation.servlet.snippet.SnippetInjectingPrintWriter, io.opentelemetry.javaagent.instrumentation.servlet.BaseServletHelper, io.opentelemetry.javaagent.instrumentation.servlet.ServletRequestContext, io.opentelemetry.javaagent.instrumentation.servlet.ServletAsyncListener, io.opentelemetry.javaagent.instrumentation.servlet.AsyncRunnableWrapper, io.opentelemetry.javaagent.instrumentation.servlet.ServletResponseContext, io.opentelemetry.javaagent.instrumentation.servlet.ServletNetAttributesGetter, io.opentelemetry.javaagent.instrumentation.servlet.ServletAdditionalAttributesExtractor, io.opentelemetry.javaagent.instrumentation.servlet.ServletRequestGetter, io.opentelemetry.javaagent.instrumentation.servlet.ServletErrorCauseExtractor, io.opentelemetry.javaagent.instrumentation.servlet.ServletRequestParametersExtractor, io.opentelemetry.javaagent.instrumentation.servlet.ServletHttpAttributesGetter, io.opentelemetry.javaagent.instrumentation.servlet.v3_0.Servlet3Accessor$Listener, io.opentelemetry.javaagent.instrumentation.servlet.v3_0.Servlet3Accessor$1, io.opentelemetry.javaagent.instrumentation.servlet.ServletSpanNameProvider, io.opentelemetry.javaagent.instrumentation.servlet.ServletMappingResolverFactory, io.opentelemetry.javaagent.instrumentation.servlet.ServletMappingResolverFactory$Mappings, io.opentelemetry.javaagent.instrumentation.servlet.ServletMappingResolverFactory$MappingResolverHolder, io.opentelemetry.javaagent.instrumentation.servlet.common.response.HttpServletResponseAdviceHelper$StartResult, io.opentelemetry.javaagent.instrumentation.servlet.common.response.HttpServletResponseAdviceHelper, io.opentelemetry.javaagent.instrumentation.servlet.common.response.HttpServletResponseAdviceHelper$1, io.opentelemetry.javaagent.instrumentation.servlet.v3_0.snippet.Servlet3SnippetInjectingResponseWrapper, io.opentelemetry.javaagent.instrumentation.servlet.javax.JavaxServletAccessor, io.opentelemetry.javaagent.instrumentation.servlet.ServletHelper, io.opentelemetry.javaagent.instrumentation.servlet.AsyncRequestCompletionListener, io.opentelemetry.javaagent.instrumentation.servlet.ServletFilterMappingResolverFactory, io.opentelemetry.javaagent.instrumentation.servlet.v3_0.Servlet3MappingResolverFactory, io.opentelemetry.javaagent.instrumentation.servlet.v3_0.Servlet3Accessor, io.opentelemetry.javaagent.instrumentation.servlet.v3_0.Servlet3FilterMappingResolverFactory]

2023-06-13 00:06:34.659Z DEBUG i.o.j.e.i.InstrumentationModule - Applying instrumentation: spring-webmvc [class io.opentelemetry.javaagent.instrumentation.spring.webmvc.v3_1.SpringWebMvcInstrumentationModule] on ParallelWebappClassLoader

@siyuniu-ms siyuniu-ms changed the title Snippet Injection Get ClassException Snippet Injection add Smoke Test for reproducing Get ClassException Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant