Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer Service Mapping per host, name and base-path #9047

Closed
mmorel-35 opened this issue Jul 26, 2023 · 1 comment · Fixed by #9061
Closed

Peer Service Mapping per host, name and base-path #9047

mmorel-35 opened this issue Jul 26, 2023 · 1 comment · Fixed by #9061
Labels
contribution welcome Request makes sense, maintainers probably won't have time, contribution would be welcome enhancement New feature or request

Comments

@mmorel-35
Copy link
Contributor

mmorel-35 commented Jul 26, 2023

Is your feature request related to a problem? Please describe.
On a service if I have

  • service A on localhost:8001
  • service B-V1 on localhost:8002/api/v1
  • service B-V2 on localhost:8002/api/v2
  • service C on mycompany.org

The otel.instrumentation.common.peer-service-mapping property is unable to map the services correctly

Describe the solution you'd like
The first thing is that I would to be able to map a service based on host and port.
And if possible also per base path so I can provide something like

otel.instrumentation.common.peer-service-mapping=localhost:8001=service-a,localhost:8002/api/v1=service-b-v1,localhost:8002/api/v2=service-b-v2,mycompany.org=service-c
@mmorel-35 mmorel-35 added the enhancement New feature or request label Jul 26, 2023
@mmorel-35 mmorel-35 changed the title Peer Service Mapping per host and name Peer Service Mapping per host, name and base-path Jul 26, 2023
@trask trask added the contribution welcome Request makes sense, maintainers probably won't have time, contribution would be welcome label Jul 26, 2023
@trask
Copy link
Member

trask commented Jul 26, 2023

hi @mmorel-35! this makes sense, we probably don't have time to implement ourselves but would welcome a contribution, let us know if you have any questions

@trask trask modified the milestone: v1.31.0 Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution welcome Request makes sense, maintainers probably won't have time, contribution would be welcome enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants