-
Notifications
You must be signed in to change notification settings - Fork 782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider changing property naming convention #2526
Comments
@jkwatson I think this needs to happen before 1.0 if we want to do it |
this is all in the auto-instrumentation module, which is still tagged as |
oh...the only one I found was |
And, this isn't in the autoconfigure module. 🤦 sorry for the brain fart. |
I don't have much of an opinion on this one at all. Consistency with auto-instrumentation is probably the most important thing. |
does the otel spec have any opinion (even implicit) in the naming of things like this? |
The Java instrumentation repo is using
-
instead of_
in property names, e.g.otel.java.disabled.resource-providers
instead ofotel.java.disabled.resource_providers
.Copying comment here from open-telemetry/opentelemetry-java-instrumentation#1414 (comment) in favor of kebab-case:
Spring Boot env var / system property mappings supports both camelCase and kebab-case, but recommends kebab-case:
And also interestingly:
The text was updated successfully, but these errors were encountered: