Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JPMS and prometheus exporter #4192

Closed
trask opened this issue Feb 19, 2022 · 2 comments · Fixed by #4196
Closed

JPMS and prometheus exporter #4192

trask opened this issue Feb 19, 2022 · 2 comments · Fixed by #4196
Labels
Feature Request Suggest an idea for this project

Comments

@trask
Copy link
Member

trask commented Feb 19, 2022

From @laurit's open-telemetry/opentelemetry-java-instrumentation#5408 (comment)

Note that when using jpms user will need to use --add-modules jdk.httpserver so it would be best if prometheus exporter did not use these classes.

Short of documenting it (e.g. here), wondering (as @laurit mentioned) if we can get rid of the dependency on com.sun.net.httpserver.

org.apache.hc.core5.http.impl.bootstrap.HttpServer in org.apache.httpcomponents.core5:httpcore5 looks reasonable (actively developed, no transitive dependencies, 831 kb, may be worth shading into the prometheus exporter to avoid conflicts, especially since this is in an impl package doesn't give much confidence in API stability).

@trask trask added the Feature Request Suggest an idea for this project label Feb 19, 2022
@anuraaga
Copy link
Contributor

For reference found upstream issue indeed doesn't seem to have been resolved

prometheus/client_java#533

httpcore seems like a reasonable option

@anuraaga
Copy link
Contributor

Though I wonder if providing a real module-info file with a declaration on jdk.httpserver is also an option

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Suggest an idea for this project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants