Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenTracing Shim: Proper handle tag/attribute ERROR #4910

Closed
Tracked by #4911
carlosalberto opened this issue Nov 2, 2022 · 0 comments · Fixed by #4962
Closed
Tracked by #4911

OpenTracing Shim: Proper handle tag/attribute ERROR #4910

carlosalberto opened this issue Nov 2, 2022 · 0 comments · Fixed by #4962

Comments

@carlosalberto
Copy link
Contributor

Currently we do a basic true/false error check for Spans, but we should update this to reflect the support in the Spec:

The error tag MUST be mapped to StatusCode:

* true maps to Error.
* false maps to Ok.
* no value being set maps to Unset.

See https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/compatibility/opentracing.md#set-tag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

OpenTracing Shim: Properly set the status based on the error tag. carlosalberto/opentelemetry-java
1 participant
@carlosalberto